webstreams: narrow ReadableStreamBYOBRequest.view to Uint8Array#62970
Closed
vedparkasharya wants to merge 1 commit intonodejs:mainfrom
Closed
webstreams: narrow ReadableStreamBYOBRequest.view to Uint8Array#62970vedparkasharya wants to merge 1 commit intonodejs:mainfrom
vedparkasharya wants to merge 1 commit intonodejs:mainfrom
Conversation
ReadableStreamBYOBRequest.view is always constructed as a Uint8Array, and the specification will be updated to enforce this. Reflect this by changing the documented return type from ArrayBufferView to Uint8Array. Refs: whatwg/streams#1367 Fixes: #62952
Member
|
Thanks, but duplicate of #62958 |
gurgunday
added
the
duplicate
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62970 +/- ##
==========================================
- Coverage 89.66% 89.66% -0.01%
==========================================
Files 706 706
Lines 219416 219416
Branches 42073 42080 +7
==========================================
- Hits 196738 196732 -6
- Misses 14576 14600 +24
+ Partials 8102 8084 -18
🚀 New features to boost your workflow:
|
Author
|
Thanks @gurgunday for pointing that out! I see that #62958 already covers this exact change. I'll close this PR to avoid duplication. Appreciate the heads-up! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadableStreamBYOBRequest.viewis always constructed as aUint8Array,and the specification will be updated to enforce this.
Refs: whatwg/streams#1367
Fixes: #62952